Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deeply nested direct hash link breaks the router if pathname not already present #1026

Closed
thescientist13 opened this issue Dec 8, 2022 · 0 comments · Fixed by #1028
Closed

deeply nested direct hash link breaks the router if pathname not already present #1026

thescientist13 opened this issue Dec 8, 2022 · 0 comments · Fixed by #1028
Assignees
@thescientist13
Labels
bug Something isn't working CLI documentation Greenwood specific docs P0 Critical issue that should get addressed ASAP Router v0.27.2 website Tasks related to the projects website / documentation
Milestone
1.0

Comments

@thescientist13
Copy link
Member

Summary

Noticed a very subtle but critical bug with the website navigation. If you go on a page with a expansion panel (the caret), and just click that, the drawer will expand but NOT change the route. (this is intentional to allow you to browse without losing your place).

However, if you then click on a sub section, the panel will just close up immediately.

For example:

  1. Load the website
  2. Click Docs
  3. Click the caret next to Configuration
  4. Click Optimization

Basically if you try and go from /docs -> /docs/configuration/#optimization

  • Expected: User would be positioned to the Optimization anchor link on the Configuration page
  • Actual: The shelf closes up

Details

So with a previous bug reported in #936, I captured a fairly comphrehensive test place in the PR but I guess I didn't really test the caret behavior that much. 🤦

So naturally, the fix here should still obvious support everything in that PR, and fix this issue as well. Maybe its finally time to get some E2E testing setup for this project...
@thescientist13 thescientist13 self-assigned this Dec 8, 2022
@thescientist13 thescientist13 converted this from a draft issue Dec 8, 2022
@thescientist13 thescientist13 added this to the 1.0 milestone Dec 8, 2022
@thescientist13 thescientist13 added bug Something isn't working P0 Critical issue that should get addressed ASAP CLI Router labels Dec 8, 2022
@thescientist13 thescientist13 changed the title deeply nested hash link breaks router if pathname not already presented deeply nested direct hash link breaks the router if pathname not already present Dec 8, 2022
@thescientist13 thescientist13 moved this from 📋 Backlog to 🏗 In progress in [Greenwood] Phase 9 - Standards and Conventions Dec 8, 2022
@thescientist13 thescientist13 added website Tasks related to the projects website / documentation documentation Greenwood specific docs labels Dec 8, 2022
@thescientist13 thescientist13 mentioned this issue Dec 8, 2022
Merged
4 tasks
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in [Greenwood] Phase 9 - Standards and Conventions Dec 8, 2022
Repository owner moved this from 👀 In review to ✅ Done in [Greenwood] Phase 9 - Standards and Conventions Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
bug Something isn't working CLI documentation Greenwood specific docs P0 Critical issue that should get addressed ASAP Router v0.27.2 website Tasks related to the projects website / documentation
Projects
No open projects
[Greenwood] Phase 9 - Standards and Conventions
Status: ✅ Done
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Bug/issue 1026 deeply nested direct hash links ProjectEvergreen/greenwood
1 participant
@thescientist13