Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESM only configuration for PostCSS plugin #1312

Closed
thescientist13 opened this issue Nov 13, 2024 · 0 comments · Fixed by #1332
Closed

ESM only configuration for PostCSS plugin #1312

thescientist13 opened this issue Nov 13, 2024 · 0 comments · Fixed by #1332
Assignees
@thescientist13
Labels
alpha.1 breaking documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins v0.31.0
Milestone
1.0

Comments

@thescientist13
Copy link
Member

thescientist13 commented Nov 13, 2024 •
edited
Loading

Type of Change

Feature

Summary

Related to #824 , it looks like PostCSS now supports ESM configuration files which means we should now be able to remove the requirement to have a CJS and an ESM configuration file.

Details

It seems from this comment it would technically have to be a .mjs file but we'll take what we can get!

In addition to updating the plugin's README file, we'll also want to post a PR to the website repo to update the docs page
https://greenwoodjs.dev/docs/plugins/postcss/#installation
@thescientist13 thescientist13 added documentation Greenwood specific docs Plugins Greenwood Plugins feature New feature or request labels Nov 13, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Nov 13, 2024
@thescientist13 thescientist13 mentioned this issue Nov 30, 2024
Merged
3 tasks
@thescientist13 thescientist13 self-assigned this Nov 30, 2024
@thescientist13 thescientist13 moved this from 📋 Backlog to 👀 In review in [Greenwood] Phase 10 - Ecosystem Compat Nov 30, 2024
@thescientist13 thescientist13 mentioned this issue Dec 13, 2024
Closed
@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) and removed feature New feature or request labels Dec 13, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in [Greenwood] Phase 10 - Ecosystem Compat Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
alpha.1 breaking documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins v0.31.0
Projects
[Greenwood] Phase 10 - Ecosystem Compat
Status: ✅ Done
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

enhancement/issue 1312 ESM-only PostCSS configuration file ProjectEvergreen/greenwood
1 participant
@thescientist13