You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As observed in thescientist13/HP_Stuff#1, it was reproduced that in the case where there is a plugin that runs an shouldOptimize / optimize resource plugin on HTML, these will not get honored in the generated HTML for SSR pages. For example, the active content plugin needs to add some "setup" <script> tags specifically for production builds thescientist13/HP_Stuff#1
And here we can see the related client side code failing since the expected optimized HTML is not there
Type of Change
Bug
Summary
As observed in thescientist13/HP_Stuff#1, it was reproduced that in the case where there is a plugin that runs an
shouldOptimize
/optimize
resource plugin on HTML, these will not get honored in the generated HTML for SSR pages. For example, the active content plugin needs to add some "setup"<script>
tags specifically for production buildsthescientist13/HP_Stuff#1
And here we can see the related client side code failing since the expected optimized HTML is not there
Details
Looking at the code, it seems pretty obvious what the issue is, we never honor any resource plugins other than Greenwood's internal plugin. 😬
https://github.com/ProjectEvergreen/greenwood/blob/v0.31.0-alpha.1/packages/cli/src/lifecycles/bundle.js#L291
Which definitely seems like an oversight I suppose since we do honor all resource plugins for intercepting 🤦♂️
https://github.com/ProjectEvergreen/greenwood/blob/v0.31.0-alpha.1/packages/cli/src/lifecycles/bundle.js#L272
The text was updated successfully, but these errors were encountered: