Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a developer I should have an app template provided by default #32

Closed
1 of 5 tasks
thescientist13 opened this issue Mar 31, 2019 · 1 comment
Closed
1 of 5 tasks
Assignees
Labels
enhancement Improve something existing (e.g. no docs, new APIs, etc) v0.2.0
Milestone

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Related to #3

App template essentially generates the App Shell for the developers application, handles routing, and general performance concerns, and should essentially be managed / owned by Greenwood by default.

Page templates are being handled by #30

Details

Although a user can certainly make their own templates/app-template.js, as it's a complicated set of orchestrations (redux, routing, bundling, etc) and as such should be considered an "advanced" API.

So by default, and as a strong recommendation, Greenwood should assume its app-template.js will be the default one used and should be maintained / tested / documented as such.

@thescientist13 thescientist13 added the enhancement Improve something existing (e.g. no docs, new APIs, etc) label Mar 31, 2019
@thescientist13 thescientist13 added this to the MVP milestone Mar 31, 2019
@thescientist13 thescientist13 self-assigned this Mar 31, 2019
@thescientist13 thescientist13 removed their assignment Apr 3, 2019
@hutchgrant
Copy link
Member

This will require #11 to be completed first, which we will need for the default 404 and index templates as well. May need to move this to Sprint 2 or move #11 to Sprint 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve something existing (e.g. no docs, new APIs, etc) v0.2.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants