You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Coming out of #26 / #44 we started with instrumenting the header component to render out purely into (Declarative) Shadow DOM. Thinking about it more, since only the mobile menu tile icon is interactive, we can probably componentize just that part, and leave the bulk of the header to just be rendered out as static (Light DOM) HTML
Details
So basically:
the overlay / mobile menu nav should be a component, that can render into a Declarative Shadow Root
From there, we would only need to ship the mobile menu component JS
The text was updated successfully, but these errors were encountered:
We can then style the popover ourselves to reproduce our overlay.
In addition, we should really be able refactor all the JS resize logic away with just media queries right? Or at the very least, with this we should be able to.
Maybe we could re-use the HTML for both menus too (or just make the nav a template)? 🤔
We should do this after #64 lands (and #67 + #61), and then as a by-product, should also resolve these issues in one fell swoop
Summary
Coming out of #26 / #44 we started with instrumenting the header component to render out purely into (Declarative) Shadow DOM. Thinking about it more, since only the mobile menu tile icon is interactive, we can probably componentize just that part, and leave the bulk of the header to just be rendered out as static (Light DOM) HTML
Details
So basically:
The text was updated successfully, but these errors were encountered: