-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data with no "user" being sent to backend #2098
Comments
I've added a hotfix for this in #2116 but we have a lot of improvements we need to make to signing in/up. I've spent a lot of time on this and need to move on to other things like the deployment to mturk, so I'm going to have @ThatOneGoat take a look at this next. Going to add various notes/thoughts below.
I'll post later if I remember more notes. |
So, after spending a while trying to find a way to re-instantiate the new authenticator in one redirect, it seems there may be some version limitations based on the version of Silhouette we are using. Basically, with this version, the documented method of removing an authenticator is by calling the Later versions of Silhouette seem more promising with what we are trying to do, but that will have to come later after we update our dependencies. In the end, I think it would be best to just leave this as an issue we tackle after we can use newer versions of Silhouette/Play. |
I actually do have one more thing we could potentially try. Most of the approaches I've tried have revolved around trying to modify the result in both discarding the old authenticator and adding the new one. However, Silhouette also supports an It would be nice to get some other's thoughts on this. |
Yeah that is an interesting thought and does sound a bit hacky. I agree that it's time to drop this issue, since it doesn't really have an effect on end users and is taking too much time. |
Closing via #2116 since we are committed to that fix over a more elegant solution. |
For both the audit and validation pages, there are errors being logged on multiple servers (I've seen it on both Seattle and CDMX). I don't know what all the implications are, idk how much data we are losing from this. But I need to investigate ASAP. It only happens sometimes, but frequently enough that it really needs to be figured out.
The errors below reference "TaskController.scala:185" and "ValidationTaskController.scala:172" which are both lines that include the code
user.get.userId
. So it looks like the "user" object is "None" for some reason.For the audit page, here is an example:
another audit example:
for the validation page, here is an example:
The text was updated successfully, but these errors were encountered: