Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need prettier CSS for mission screens outside of English language #3257

Closed
misaugstad opened this issue Jun 15, 2023 · 4 comments · Fixed by #3297
Closed

Need prettier CSS for mission screens outside of English language #3257

misaugstad opened this issue Jun 15, 2023 · 4 comments · Fixed by #3297

Comments

@misaugstad
Copy link
Member

Brief description of problem/feature

The CSS looks a little bit rough in languages that are more verbose than English for our new mission start screens. And they are so pretty, I want them to be pretty in other languages! There are two examples below, but it's consistent across Spanish, Dutch, and German, and for all the different label types on both Validate and Explore.
Screenshot from 2023-06-14 14-15-27
Screenshot from 2023-06-14 14-15-33
Screenshot from 2023-06-14 14-15-47

@jonfroehlich
Copy link
Member

Yes, agree. And nice diligent eye on this one!

I just mentioned this here: #3259 (comment)

It should be pretty straightforward. Maybe check string length and dynamically change CSS to better center content text.

image image

@hoominchu
Copy link
Collaborator

Just saw this issue. I am not sure what approach is being explored currently but we can have a function that adjusts the font size to fit it on the label by checking if the 'container' element has a scroll (horizontal and vertical) and if yes, reduce the font size by 0.05px (or some other small value). Repeat until there is no scroll or we hit a minimum font value.

I can help provide more details if needed.

@jonfroehlich
Copy link
Member

I don't think we should change the font size necessarily. To me, it's purely about spacing. See the screenshots above.

@hoominchu
Copy link
Collaborator

Ah okay. We can add a 'locale' class to the mission screens div (maybe we do this already) and then have CSS with more specific selectors to handle those cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants