Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Validation interface: Uncaught ReferenceError: zoom is not defined #3400

Closed
jonfroehlich opened this issue Oct 6, 2023 · 9 comments · Fixed by #3414
Closed

In Validation interface: Uncaught ReferenceError: zoom is not defined #3400

jonfroehlich opened this issue Oct 6, 2023 · 9 comments · Fixed by #3414

Comments

@jonfroehlich
Copy link
Member

I tried to click disagree and got an exception.

image

@hoominchu
Copy link
Collaborator

I was not able to reproduce this.

@misaugstad
Copy link
Member

I also could not reproduce this anywhere. I took a look at where the error message originates... It is some code that I touched recently, but there shouldn't be any issues with it... Let's leave it open for a little while and see if it pops up again. If it happens occasionally, it might be some sort of race condition and we may need to enforce an ordering of some code execution somewhere

@jonfroehlich
Copy link
Member Author

Had this happen again on the exact same image in Walla Walla. Perhaps it's something unique to that pano?

Notice how the curb ramp label seems way off too.

Uncaught ReferenceError: zoom is not defined
    at Label.validate (SVValidate.js:912:94)
    at PanoramaContainer.validateLabel (SVValidate.js:2794:40)
    at validateLabel (SVValidate.js:1281:35)
    at HTMLButtonElement.<anonymous> (SVValidate.js:1247:9)
    at HTMLButtonElement.dispatch (jquery-1.12.2.min.js:3:12444)
    at r.handle (jquery-1.12.2.min.js:3:9173)

@jonfroehlich
Copy link
Member Author

It's not just about 'agree' or 'disagree' but the buttons become non-functional.

It's pretty easy to replicate this problem in Walla Walla. I've run into it pretty darn quickly when validating these (while multitasking during a Zoom call). @misaugstad, I think you'll see this if you try to investigate on Walla Walla.

Note that the placed label always seems to be way off--so something isn't be recorded correctly (or the Zoom isn't being set correctly— @misaugstad recently updated the zoom code in the validation UI and my guess is something here is triggering the bug).

image

Uncaught ReferenceError: zoom is not defined
    at Label.validate (SVValidate.js:912:94)
    at PanoramaContainer.validateLabel (SVValidate.js:2794:40)
    at validateLabel (SVValidate.js:1281:35)
    at HTMLButtonElement.<anonymous> (SVValidate.js:1251:9)
    at HTMLButtonElement.dispatch (jquery-1.12.2.min.js:3:12444)
    at r.handle (jquery-1.12.2.min.js:3:9173)

@jonfroehlich jonfroehlich changed the title Disagree no longer works in validate In Validation interface: Uncaught ReferenceError: zoom is not defined Oct 13, 2023
@bgoblirsch
Copy link

bgoblirsch commented Oct 20, 2023

This happens on every validation I try to disagree with, so I am never able to attach a message.

Edit: I mean it happens any time I try to attach a message with a disagree. The message I type gets cleared when I click disagree and it does not get submitted. I can then click disagree but the message is not attached.

@jonfroehlich
Copy link
Member Author

Hmm, try reloading. Something is definitely up with this. We will investigate. Thanks for your comment @bgoblirsch

@bgoblirsch
Copy link

@jonfroehlich This bug has occurred since I started project sidewalk about a month ago. I've never been able to attach a message.

@jonfroehlich
Copy link
Member Author

OK. Thanks for letting us know.

@misaugstad
Copy link
Member

Thank you @bgoblirsch! The issue has to do with inputting a message along with a validation. This will make it much easier to track down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants