Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labeling guide links point to different places #3420

Closed
jonfroehlich opened this issue Nov 3, 2023 · 2 comments
Closed

Labeling guide links point to different places #3420

jonfroehlich opened this issue Nov 3, 2023 · 2 comments

Comments

@jonfroehlich
Copy link
Member

We've found that some cities want to point folks to their own custom labeling guide (for example, in Taipei, New Tapei, and Keelung).

However, in our html, we have multiple places that point to this labeling guide and they appear to be hard coded rather than, say, referencing a labeling guide location variable. And, currently, these different links take you to different places.

If you click on "How to label", you go here: https://sidewalk-taipei.cs.washington.edu/assets/documents/labeling-guide-Taiwan.pdf

image

If you click on labeling guide in the leaderboard, however, you go just to the English html page. This should be fixed.
image

@misaugstad
Copy link
Member

Given that we are hoping to move over to a more easily updated labeling guide in Google Docs (#3282), I think that we should avoid the overhead of storing this in a variable, and just check if there are any other places that link to the labeling guide and update those for now!

@misaugstad
Copy link
Member

Closing via #3449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants