Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add left/right keyboard shortcuts to Gallery expanded view #3612

Closed
misaugstad opened this issue Aug 9, 2024 · 4 comments · Fixed by #3613
Closed

Add left/right keyboard shortcuts to Gallery expanded view #3612

misaugstad opened this issue Aug 9, 2024 · 4 comments · Fixed by #3613

Comments

@misaugstad
Copy link
Member

Brief description of problem/feature

When the expanded view is open, I think that we should have the following keyboard shortcuts at a minimum:

  • Validate agree: A and Y
  • Validate disagree: D and N
  • Validate unsure: U
  • Go to previous label: left arrow key
  • Go to next label: right arrow key
@jonfroehlich
Copy link
Member

Yes! :)

@jsomeara
Copy link
Collaborator

jsomeara commented Aug 10, 2024

Hi! I was gonna give this shot until I realized I don't have any labels to validate in my DB. Does anyone know if there's a way to add/simulate labels in a dev environment with a DB that has its PII scrubbed?

(Or I might just be misunderstanding when the labels get added to the DB after the exploration phase. Please forgive my ignorance!)

Edit:

It seems my labels are showing up in the gallery of the dev environment but for some reason the validate page doesn't load anything. I get this error in the console:

TypeError: Cannot read properties of undefined (reading 'labels_validated')

@misaugstad
Copy link
Member Author

It seems my labels are showing up in the gallery of the dev environment but for some reason the validate page doesn't load anything. I get this error in the console:

I think that you probably just need to add even more labels for Validate to work! And you also need to add labels with a different account than the account you use to validate the labels. I think that you can see your own labels in Gallery, but not Validate

@jsomeara
Copy link
Collaborator

jsomeara commented Aug 12, 2024

I think that you probably just need to add even more labels for Validate to work! And you also need to add labels with a different account than the account you use to validate the labels. I think that you can see your own labels in Gallery, but not Validate

Good to know if I ever need to work on the validate page! My apologies for clogging up this thread earlier.


Made a PR for the keyboard shortcuts: #3613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants