-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What to do about Access Score for v2? #457
Comments
We could start with the last option (temp solution) till we come up with a solution to optimize rendering labels faster for implementing the third option. Not sure how long the third option would take. @tongning could implement the temp solution. |
From a cursory search I think giving the website the ability to screenshot itself would be fairly difficult without installing additional tools on the server. Perhaps another machine should be set up (on AWS, etc.) to take and host the screenshots, and the main site just has an img href to the external image. Of course the screenshot can also be updated manually. Either way, it seems rather clunky. |
We definitely should not update the screenshot manually. Generally, in UI programming, the way you create screenshots is to take the drawn output--the Canvas in this case--and save it to a file. I guess the key is where would we run this code given that our server is unix and doesn't have a browser (which Anthony rightly pointed out). Assuming we had a machine (on AWS or otherwise) that could run a browser, couldn't we just do something like this: http://stackoverflow.com/questions/923885/capture-html-canvas-as-gif-jpg-png-pdf/3514404#3514404 So, I think the approach would be:
Alternatively, @tongning could investigate how to optimize the Admin map and then we could just adapt that. |
While taking screenshots would certainly resolve the performance problem, it is still a workaround and given the time we have to spend on setting up another machine to take these screenshots I don't think it's worth it. I have some suggestions to improve the performance of the current visualization:
|
I agree, the time needed to set up and maintain the screenshotting infrastructure probably isn't worth it for something that can only be highly temporary. Best used as a last resort if all methods to make the map faster fail. |
I agree as well. Thanks for weighing in. Honestly, this is really under the purview of @Manaswis' work as she is directing the Access Score visualization development and research. While I think @tongning could totally do this, I think it might make sense for @Manaswis to spend a bit of time investigating the problem with profilers and coming up with fixes (@Soben713 got us started with #380). |
Regarding the profiling and the optimization that will happen in the future. I think there are three parts that could be bottlenecks but I think the rendering is the issue.
|
Thanks for the awesome suggestions everyone! I will investigate this after the v2 tasks are done. |
Thanks Kotaro. My feeling is that we still take down Access Score for now and, instead, have a View Results link that does not calculate any access score metrics. Instead, it simply shows end users all of the data that we've collected so far. The easiest way to do this, in my mind, would be via a dot-based visualization like we have on the Admin Page. All we have to do is make this faster and more interactive. We should also consider having something that shows results like this on the landing page. Need not be interactive, however, imo. |
@jonfroehlich Yes, I figured that the team will go for one of the options you mentioned previously :) I think pre-rendering a raster image makes sense. I just wanted to follow up with the points that Soheil raised above so when Manaswi (or anyone who will be responsible for this) will be working on this she knows what/where to look. |
Sure, got it. And to be clear, I think we, as a group, decided not to pursue rasterized image option but rather to speed up the Admin page visualization and deploy something similar to View Results link on landing page. |
Oh, I see. I think it makes sense :) If the visualization will show the dots at the zoom level in which the entire DC can be seen, however, I think rendering things on canvas is the way to go (as opposed to rendering SVG elements within a bounded viewport as Soheil and I mentioned). I think there are just too many elements to render at the city level. |
I agree. Render with Canvas object. |
Adding my suggestion from the v2 launch date email here:
|
Access Score has become unusable. The webpage takes too long to load and does not provide the user any feedback about what is happening (#344). Moreover, the access score calculations themselves do not seem to accurately represent the density and severity of found accessibility problems (#359).
While I hesitate to add any more tasks to v2, especially when we missed our Nov 15th launch date, I think continuing to have Access Score, in its current form, reflects poorly on our website. Some possible steps forward:
Tagging @kotarohara, @Manaswis, @Soben713, and @tongning for discussion.
The text was updated successfully, but these errors were encountered: