Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Results Choropleth: Logging of neighborhood clicks should be different than the landing page choropleth #905

Closed
manaswisaha opened this issue Jul 25, 2017 · 2 comments
Closed

Results Choropleth: Logging of neighborhood clicks should be different than the landing page choropleth #905

manaswisaha opened this issue Jul 25, 2017 · 2 comments
Assignees
@misaugstad
Labels
Priority High

Comments

@manaswisaha
Copy link
Member

manaswisaha commented Jul 25, 2017 •
edited
Loading

The logs below will give you an idea.

image

Tagging @misaugstad and @sbower213
@ghost ghost added the in progress label Jul 26, 2017
@misaugstad misaugstad mentioned this issue Jul 26, 2017
Merged
@jonfroehlich
Copy link
Member

Yes, definitely. Surprised that: (i) this wasn't coded up correctly at first (given that it seems obvious and we talked about appropriate logging in Slack) and (ii) that the original choropleth doesn't have a more descriptive name either (e.g., landing_page_choropleth or CompletionRateChoropleth).

Good catch @Manaswis!

@manaswisaha manaswisaha mentioned this issue Jul 26, 2017
Merged
@manaswisaha
Copy link
Member Author

Closed via #906

@ghost ghost removed the pull-request-submitted label Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@misaugstad misaugstad

Labels
Priority High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonfroehlich @manaswisaha @misaugstad