Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insert): return array when given an array of one input #285

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

rintaun
Copy link
Member

@rintaun rintaun commented Jul 21, 2021

Before:

The types for insert suggested that, given an array with one element, the method would return an array of inserted rows. However, it actually returned an object, leading to errors.

After:

insert actually returns an array of results when given an array with a single row input

@rintaun rintaun added the automerge Automatically merge the PR when checks are passing and approval has been obtained label Jul 21, 2021
@kodiakhq kodiakhq bot merged commit c4ef47b into main Jul 21, 2021
@kodiakhq kodiakhq bot deleted the fix/insert-many-with-one-input branch July 21, 2021 20:20
rintaun pushed a commit that referenced this pull request Jul 21, 2021
### [1.9.1](v1.9.0...v1.9.1) (2021-07-21)

### Bug Fixes

* **insert:** return array when given an array of one input ([a9a4a8c](a9a4a8c))
* **insert:** return array when given an array of one input ([#285](#285)) ([c4ef47b](c4ef47b))
@rintaun
Copy link
Member Author

rintaun commented Jul 21, 2021

🎉 This PR is included in version 1.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge the PR when checks are passing and approval has been obtained released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant