Skip to content

docs(core): fix memory address column comment #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
radik878 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs(core): fix memory address column comment #421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions crates/core/machine/src/memory/instructions/columns.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,11 @@ pub struct MemoryInstructionsColumns<T> {
/// Whether this is a sc instruction.
pub is_sc: T,

/// The relationships among addr_word, addr_aligned, and addr_offset is as follows:
/// addr_aligned = addr_word - addr_offset
/// addr_ls_two_bits = addr_word % 4
/// Note that this all needs to be verified in the AIR
/// The relationships among `addr_word`, `addr_aligned`, and `addr_ls_two_bits` are as follows:
/// `addr_ls_two_bits` is the least significant two bits of the unaligned address.
/// `addr_aligned` is the aligned base address.
/// In the AIR, we constrain `reduce(addr_word) = addr_aligned + addr_ls_two_bits` and
/// constrain `addr_ls_two_bits` via a byte lookup (`addr_ls_two_bits = addr_word[0] & 0b11`).
pub addr_word: Word<T>,

/// The aligned address.
Expand Down