Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escaping underscore breaks link URLs that contain this character #61

Closed
enriquecastl opened this issue Jan 4, 2022 · 2 comments
Closed

Escaping underscore breaks link URLs that contain this character #61

enriquecastl opened this issue Jan 4, 2022 · 2 comments

Comments

@enriquecastl
Copy link

Version

1.6.1

What is the problem?

When serializing a document, Prosemirror-markdown breaks links with URLs that that contain underscore characters. The change was introduced in: 9915597

How to reproduce

The following sandbox contains a reproducible script: https://codesandbox.io/s/broken-links-prosemirror-markdown-r9ez0
@marijnh marijnh closed this as completed in 8e456de Jan 4, 2022
@marijnh
Copy link
Member

marijnh commented Jan 4, 2022

Attached patch should fix this.

@enriquecastl
Copy link
Author

Thanks for the quick fix @marijnh 🙇🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marijnh @enriquecastl