This repository has been archived by the owner on Sep 24, 2024. It is now read-only.
Require email addresses to be unique #56
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsluijk
added
✨ Enhancement
Gerbuuun
reviewed
Dec 15, 2022
There was a problem hiding this comment.
Ik ben nog wel steeds van mening dat email en telefoonnummer gewoon in de member model moet. Dan hebben we alle verplichte data op één plek en hoeven we ook niet allemaal checks te doen. Dit scheelt dan ook weer complexiteit. Alle uitbreidingen (studies, memberships, andere contact info, etc) kunnen dan als extensies aan de member gelinkt worden.
|
Hmm, ja, dat is misschien wel handig. Moet ik dan even naar kijken. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require email addresses to be unique
🔗 Linked issue
Closes #51.
❓ Wat voor soort aanpassing?
📚 Beschrijving
This PR restricts contact emails to be unique across the entire system.
Depends on #55 to be merged.
📝 Checklist