Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Share "proton-account" web app #205

Closed
vladimiry opened this issue Sep 30, 2020 · 3 comments
Closed

[feature request] Share "proton-account" web app #205

vladimiry opened this issue Sep 30, 2020 · 3 comments

Comments

@vladimiry
Copy link

vladimiry commented Sep 30, 2020

The one that got recently deployed at https://account.protonmail.com.

Also is this app going to be deployed at https://account.protonmail.ch (CH entry point) and https://account.protonirockerxow.onion (entry point via TOR)?

CC @dhoko

@vladimiry
Copy link
Author

Looks like I could try building the web apps with appMode=standalone proton-pack/webpack arg and get the SSO mode disabled.

@dhoko
Copy link
Collaborator

dhoko commented Sep 30, 2020

👋

Sorry, i forgot to change the visibility of the repo 🤦 https://github.com/ProtonMail/proton-account
Hum, the beta is only on protonmail.com, not on the ch version. Same for tor today as account is part of the beta too, all apps are on a subdomain now.

To build the SSO we have an appMode sso so the apps are able to work on a subdomain.
Standalone mode is still possible if you want <mail-webclient>/calendar etc.

Btw, no more "tricks" to get translations. npm ci is enough. We removed the hook, and it's a npm dep now.

@vladimiry
Copy link
Author

Thanks for a fast and detailed feedback. Closing the issue as resolved. Might come back later when I have tried the updated projects in action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants