Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize expiration for generation of keys #54

Open
klische opened this issue Jun 30, 2020 · 1 comment
Open

Parameterize expiration for generation of keys #54

klische opened this issue Jun 30, 2020 · 1 comment
Labels
v2 Targeting GopenPGP v2

Comments

@klische
Copy link
Contributor

klische commented Jun 30, 2020

When generating keys (https://github.com/ProtonMail/gopenpgp#generate-key), there are no parameters to set the expiration date for the PGP keys.

There seems to be SigLifetimeSecs, KeyLifetimeSecs in the packet signature, but is not implemented anywhere.

Can we get this feature? Happy to help with a PR potentially.

@wussler
Copy link
Collaborator

wussler commented Jul 2, 2020

Hi @klische, your contribution would be more than welcome.

I'd personally add a function in crypto/key.go:

func GenerateKeyWithExpiration(name, email string, keyType string, bits int, expiration int64) (*Key, error)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 Targeting GopenPGP v2
Projects
None yet
Development

No branches or pull requests

3 participants