Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEFAULT_FORWARDED_PORT_FILEPATH global variable has side effects #6

Open
3 tasks done
Steinhagen opened this issue Feb 21, 2025 · 0 comments
Open
3 tasks done

Comments

@Steinhagen
Copy link

We are happy to answer your questions about the code or discuss technical ideas.

The following commit introduces the DEFAULT_FORWARDED_PORT_FILEPATH global variable that has side effects (generates directories due to VPNExecutionEnvironment()). As a result, every time you import the core python module, the directories will be generated:
https://github.com/ProtonVPN/python-proton-vpn-api-core/commit/2bed80d42ef199ea1d8d90e13be843cae3e3850c#diff-a477ea526f47d9a15ba19e31f1e9a374bdf99f676be865d5b99563a665709cd3R26

Please complete the following checklist (by adding [x]):

  • I have searched open and closed issues for duplicates
  • This isn't a feature request
  • This is not a report about my app not working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant