Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract block hardness in block extractor #297

Closed
1 task done
user622628252416 opened this issue Nov 16, 2024 · 3 comments
Closed
1 task done

Extract block hardness in block extractor #297

user622628252416 opened this issue Nov 16, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@user622628252416
Copy link
Contributor

I've searched existing issues and couldn't find a duplicate.

  • I confirm this is not a duplicate.

Is your feature request related to a problem? Please describe.

Block hardness is required for calculating block breaking speed, which is needed to determine whether a block was broken instantly or the breaking was cancelled, as the client does not send a breaking finished packet when a block was broken instantly, even in survival mode.

Describe the solution you'd like

block hardness should be extracted and added to blocks.json

@user622628252416 user622628252416 added the enhancement New feature or request label Nov 16, 2024
@user622628252416
Copy link
Contributor Author

user622628252416 commented Nov 16, 2024

While you're at it, whether a player can stand on a block should also be extracted. That's required for getting the top block when spawning players for example, currently that just checks whether a block is air

@Snowiiii
Copy link
Member

While you're at it, whether a player can stand on a block should also be extracted. That's required for getting the top block when spawning players for example, currently that just checks whether a block is air

Im not sure what do you mean by "whether a player can stand on a block"

@user622628252416
Copy link
Contributor Author

While you're at it, whether a player can stand on a block should also be extracted. That's required for getting the top block when spawning players for example, currently that just checks whether a block is air

Im not sure what do you mean by "whether a player can stand on a block"

What I meant was whether the block has a collision shape, but now that I think about it that doesn't make much sense, as collisions are a lot more complex than that. I also didn't realize before that there are in fact already collision shapes in blocks.json, so sorry for not doing my due diligence and thanks for adding block hardness!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants