Completely replace fastnbt with our own NBT crate

[Snowiiii]

I've searched existing issues and couldn't find a duplicate.

• I confirm this is not a duplicate.

Is your feature request related to a problem? Please describe.

Our own NBT crate currently does work great when serializing values into NBT, But deserialzing seems not to really work

Describe the solution you'd like

Fix our NBT crate and finally remove fastnbt. This should also finally allow #283 to be merged

[asodugf12]

Now that I am out of the translation issue, can I take up this one?

[Snowiiii]

Now that I am out of the translation issue, can I take up this one?

Yes, Please would be very nice

[Snowiiii]

@asodugf12 How its going ?

[asodugf12]

oop, Ive been a bit busy the past few days so I'll start work now. Can I get a briefing on the problems with the current system?

[Snowiiii]

oop, Ive been a bit busy the past few days so I'll start work now. Can I get a briefing on the problems with the current system?

So Serializing (data->NBT) works fine, no problems. But Deserializing (NBT->data) which is done in pumpkin-world does not work for some reason

[asodugf12]

Is there any specific function that doesnt work, or what is the function output against the desired output. I forgot my charger, so there id a limited time window I could work on things and i just wanna make sure i could be most productive

[Snowiiii]

Is there any specific function that doesnt work, or what is the function output against the desired output. I forgot my charger, so there id a limited time window I could work on things and i just wanna make sure i could be most productive

Hey, I'm not sure, its just not working, I first tough it had something to do with Arrays but after testing not only Arrays are not working, the whole Deserialization is broken. You don't have any "limited time window", But ofc as sooner as better

[asodugf12]

This comes a little late, I've been diving into serde and I just realised our NBT crate is a little more inspired than I previously thought. Maybe the issues comes from the parts we snipped off?

[asodugf12]

Also, I'd very much appreciate some examples where out crate fails. Thanks a lot!

[asodugf12]

From the look of things, I want to try and implement our own Visitor for the deserialization. What do you think?

[neeleshpoli]

Also, I'd very much appreciate some examples where out crate fails. Thanks a lot!

In instances where fastnbt is used, you can replace it with pumpkin nbt and see the errors that occur. We don't have specific examples.

From the look of things, I want to try and implement our own Visitor for the deserialization. What do you think?

I think alex really wants to get this working, so I think he would be ok with this.

[asodugf12]

I did replace it and did cargo run without issues. I couldn't test the server however, since I don't have official minecraft. Alex did tell me that the unnamed version worked fine, but named tries to copy too many bytes into a buffer.

I also noticed that from_bytes_unnamed has issues reading nbt files, but I'll look into that later :D

[asodugf12]

It did not have issues reading nbt files, I used the wrong function lol