Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointless transaction in onlineshop.sql #60

Open
djaenecke opened this issue Aug 15, 2023 · 0 comments
Open

Pointless transaction in onlineshop.sql #60

djaenecke opened this issue Aug 15, 2023 · 0 comments

Comments

@djaenecke
Copy link

Just saw a (minor) issue in the database setup file (database/onlineshop.sql):

START TRANSACTION;
[…]
CREATE DEFINER=`root`@`localhost` PROCEDURE
[…]
CREATE TABLE
[…]
COMMIT;

Any DDL statement causes an implicit commit, so you should either completely remove the transaction or wrap only the DML statements inside.
cf. https://dev.mysql.com/doc/refman/8.0/en/implicit-commit.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@djaenecke