Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] DRG Rotation breaks after opener. oGCD skills are replaced with True Thrust #100

Closed
timemage21 opened this issue Nov 23, 2024 · 10 comments
Assignees
Labels
Bug Something isn't working

Comments

@timemage21
Copy link

I've been testing this issue for a bit, and haven't come up with a permanent fix yet. Mainly from observation after finishing opener, around the time Wyrmwind Thrust is available in the combo oGCDs stop weaving and True Thrust becomes the default suggestion for oGCD casts.

  • It doesn't appear casting any abilities manually will reset this behavior once started, including Wyrmwind Thrust
  • Other jobs tested do not experience the same behavior on my client
  • This happens in both advanced and simple modes
  • Restarting Wraith combo also appears to correct the behavior

I've gathered a log that includes 3 examples of different behaviors - https://www.fflogs.com/reports/xrTMJQjdKL82PWRD

  • First fight is advanced mosde
  • 2nd fight is simple mode
  • 3rd fight is simple mode after restarting wraith combo
    WrathDebug.txt
@zbee zbee added the Bug Something isn't working label Nov 23, 2024
@Kagekazu
Copy link
Member

This is fixed in Pull Request #62
So next release it will be fixed.

@timemage21
Copy link
Author

I've tested this again after updating this morning and exact same behavior appears. Reloading the addon after the game launches also still corrects the issue
WrathDebug.txt

@Kagekazu
Copy link
Member

I've tested this again after updating this morning and exact same behavior appears. Reloading the addon after the game launches also still corrects the issue WrathDebug.txt

I cannot seem to replicate this bug then.
Can u send a video of this behavior being on 1.0.0.2?

@timemage21
Copy link
Author

@zbee zbee reopened this Nov 24, 2024
@Kagekazu
Copy link
Member

Is it possible to screenshot ur actual settings? To make sure it's not some error in settings ^.^

@timemage21
Copy link
Author

ffxiv_11242024_131110_857
ffxiv_11242024_131045_649
ffxiv_11242024_131048_496
ffxiv_11242024_131051_270
ffxiv_11242024_131104_092

I've deleted everything I could find related to sloth/wrath combo in %AppData%\Roaming\XIVLauncher\pluginConfigs as well when troubleshooting and set up configs myself.

@timemage21
Copy link
Author

13:19:16.148 | INF | [PLUGINM] "WrathCombo" defaultState: True wantedByAnyProfile: True loadPlugin: True
13:19:16.148 | INF | [LOCALPLUGIN] Loading WrathCombo.dll
13:19:16.907 | INF | [WrathCombo] This is ECommons v2.2.0.2 (release build without forms) and WrathCombo v1.0.0.2. Hello!
13:19:21.169 | INF | [WrathCombo] Cached 1255 preset attributes.
13:19:21.181 | INF | [LOCALPLUGIN] Finished loading "WrathCombo"
13:21:05.659 | ERR | [WrathCombo] Preset error
System.NullReferenceException: Object reference not set to an instance of an object.
at XIVSlothCombo.Combos.PvE.DRG.DRG_AOE_AdvancedMode.Invoke(UInt32 actionID, UInt32 lastComboMove, Single comboTime, Byte level) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Combos\PvE\DRG\DRG.cs:line 550
at XIVSlothCombo.CustomComboNS.CustomCombo.TryInvoke(UInt32 actionID, Byte level, UInt32 lastComboMove, Single comboTime, UInt32& newActionID, IGameObject targetOverride) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\CustomCombo\CustomCombo.cs:line 65
at XIVSlothCombo.Core.IconReplacer.GetIconDetour(IntPtr actionManager, UInt32 actionID) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Core\IconReplacer.cs:line 76
13:21:05.661 | ERR | [WrathCombo] Preset error
System.NullReferenceException: Object reference not set to an instance of an object.
at XIVSlothCombo.Combos.PvE.DRG.DRG_AOE_AdvancedMode.Invoke(UInt32 actionID, UInt32 lastComboMove, Single comboTime, Byte level) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Combos\PvE\DRG\DRG.cs:line 550
at XIVSlothCombo.CustomComboNS.CustomCombo.TryInvoke(UInt32 actionID, Byte level, UInt32 lastComboMove, Single comboTime, UInt32& newActionID, IGameObject targetOverride) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\CustomCombo\CustomCombo.cs:line 65
at XIVSlothCombo.Core.IconReplacer.GetIconDetour(IntPtr actionManager, UInt32 actionID) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Core\IconReplacer.cs:line 76
13:21:05.669 | ERR | [WrathCombo] Preset error
System.NullReferenceException: Object reference not set to an instance of an object.
at XIVSlothCombo.Combos.PvE.DRG.DRG_AOE_AdvancedMode.Invoke(UInt32 actionID, UInt32 lastComboMove, Single comboTime, Byte level) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Combos\PvE\DRG\DRG.cs:line 550
at XIVSlothCombo.CustomComboNS.CustomCombo.TryInvoke(UInt32 actionID, Byte level, UInt32 lastComboMove, Single comboTime, UInt32& newActionID, IGameObject targetOverride) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\CustomCombo\CustomCombo.cs:line 65
at XIVSlothCombo.Core.IconReplacer.GetIconDetour(IntPtr actionManager, UInt32 actionID) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Core\IconReplacer.cs:line 76
13:21:05.669 | ERR | [WrathCombo] Preset error
System.NullReferenceException: Object reference not set to an instance of an object.
at XIVSlothCombo.Combos.PvE.DRG.DRG_AOE_AdvancedMode.Invoke(UInt32 actionID, UInt32 lastComboMove, Single comboTime, Byte level) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Combos\PvE\DRG\DRG.cs:line 550
at XIVSlothCombo.CustomComboNS.CustomCombo.TryInvoke(UInt32 actionID, Byte level, UInt32 lastComboMove, Single comboTime, UInt32& newActionID, IGameObject targetOverride) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\CustomCombo\CustomCombo.cs:line 65
at XIVSlothCombo.Core.IconReplacer.GetIconDetour(IntPtr actionManager, UInt32 actionID) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Core\IconReplacer.cs:line 76
13:21:05.677 | ERR | [WrathCombo] Preset error
System.NullReferenceException: Object reference not set to an instance of an object.
at XIVSlothCombo.Combos.PvE.DRG.DRG_AOE_AdvancedMode.Invoke(UInt32 actionID, UInt32 lastComboMove, Single comboTime, Byte level) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Combos\PvE\DRG\DRG.cs:line 550
at XIVSlothCombo.CustomComboNS.CustomCombo.TryInvoke(UInt32 actionID, Byte level, UInt32 lastComboMove, Single comboTime, UInt32& newActionID, IGameObject targetOverride) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\CustomCombo\CustomCombo.cs:line 65
at XIVSlothCombo.Core.IconReplacer.GetIconDetour(IntPtr actionManager, UInt32 actionID) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Core\IconReplacer.cs:line 76
13:21:05.678 | ERR | [WrathCombo] Preset error
System.NullReferenceException: Object reference not set to an instance of an object.
at XIVSlothCombo.Combos.PvE.DRG.DRG_AOE_AdvancedMode.Invoke(UInt32 actionID, UInt32 lastComboMove, Single comboTime, Byte level) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Combos\PvE\DRG\DRG.cs:line 550
at XIVSlothCombo.CustomComboNS.CustomCombo.TryInvoke(UInt32 actionID, Byte level, UInt32 lastComboMove, Single comboTime, UInt32& newActionID, IGameObject targetOverride) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\CustomCombo\CustomCombo.cs:line 65
at XIVSlothCombo.Core.IconReplacer.GetIconDetour(IntPtr actionManager, UInt32 actionID) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Core\IconReplacer.cs:line 76
13:21:05.686 | ERR | [WrathCombo] Preset error
System.NullReferenceException: Object reference not set to an instance of an object.
at XIVSlothCombo.Combos.PvE.DRG.DRG_AOE_AdvancedMode.Invoke(UInt32 actionID, UInt32 lastComboMove, Single comboTime, Byte level) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Combos\PvE\DRG\DRG.cs:line 550
at XIVSlothCombo.CustomComboNS.CustomCombo.TryInvoke(UInt32 actionID, Byte level, UInt32 lastComboMove, Single comboTime, UInt32& newActionID, IGameObject targetOverride) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\CustomCombo\CustomCombo.cs:line 65
at XIVSlothCombo.Core.IconReplacer.GetIconDetour(IntPtr actionManager, UInt32 actionID) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Core\IconReplacer.cs:line 76
13:21:05.686 | ERR | [WrathCombo] Preset error
System.NullReferenceException: Object reference not set to an instance of an object.
at XIVSlothCombo.Combos.PvE.DRG.DRG_AOE_AdvancedMode.Invoke(UInt32 actionID, UInt32 lastComboMove, Single comboTime, Byte level) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Combos\PvE\DRG\DRG.cs:line 550
at XIVSlothCombo.CustomComboNS.CustomCombo.TryInvoke(UInt32 actionID, Byte level, UInt32 lastComboMove, Single comboTime, UInt32& newActionID, IGameObject targetOverride) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\CustomCombo\CustomCombo.cs:line 65
at XIVSlothCombo.Core.IconReplacer.GetIconDetour(IntPtr actionManager, UInt32 actionID) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Core\IconReplacer.cs:line 76
13:21:05.695 | ERR | [WrathCombo] Preset error
System.NullReferenceException: Object reference not set to an instance of an object.
at XIVSlothCombo.Combos.PvE.DRG.DRG_AOE_AdvancedMode.Invoke(UInt32 actionID, UInt32 lastComboMove, Single comboTime, Byte level) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Combos\PvE\DRG\DRG.cs:line 550
at XIVSlothCombo.CustomComboNS.CustomCombo.TryInvoke(UInt32 actionID, Byte level, UInt32 lastComboMove, Single comboTime, UInt32& newActionID, IGameObject targetOverride) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\CustomCombo\CustomCombo.cs:line 65
at XIVSlothCombo.Core.IconReplacer.GetIconDetour(IntPtr actionManager, UInt32 actionID) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Core\IconReplacer.cs:line 76
13:21:05.696 | ERR | [WrathCombo] Preset error
System.NullReferenceException: Object reference not set to an instance of an object.
at XIVSlothCombo.Combos.PvE.DRG.DRG_AOE_AdvancedMode.Invoke(UInt32 actionID, UInt32 lastComboMove, Single comboTime, Byte level) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Combos\PvE\DRG\DRG.cs:line 550
at XIVSlothCombo.CustomComboNS.CustomCombo.TryInvoke(UInt32 actionID, Byte level, UInt32 lastComboMove, Single comboTime, UInt32& newActionID, IGameObject targetOverride) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\CustomCombo\CustomCombo.cs:line 65
at XIVSlothCombo.Core.IconReplacer.GetIconDetour(IntPtr actionManager, UInt32 actionID) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Core\IconReplacer.cs:line 76
13:21:05.705 | ERR | [WrathCombo] Preset error
System.NullReferenceException: Object reference not set to an instance of an object.
at XIVSlothCombo.Combos.PvE.DRG.DRG_AOE_AdvancedMode.Invoke(UInt32 actionID, UInt32 lastComboMove, Single comboTime, Byte level) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Combos\PvE\DRG\DRG.cs:line 550
at XIVSlothCombo.CustomComboNS.CustomCombo.TryInvoke(UInt32 actionID, Byte level, UInt32 lastComboMove, Single comboTime, UInt32& newActionID, IGameObject targetOverride) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\CustomCombo\CustomCombo.cs:line 65
at XIVSlothCombo.Core.IconReplacer.GetIconDetour(IntPtr actionManager, UInt32 actionID) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Core\IconReplacer.cs:line 76
13:21:05.705 | ERR | [WrathCombo] Preset error
System.NullReferenceException: Object reference not set to an instance of an object.
at XIVSlothCombo.Combos.PvE.DRG.DRG_AOE_AdvancedMode.Invoke(UInt32 actionID, UInt32 lastComboMove, Single comboTime, Byte level) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Combos\PvE\DRG\DRG.cs:line 550
at XIVSlothCombo.CustomComboNS.CustomCombo.TryInvoke(UInt32 actionID, Byte level, UInt32 lastComboMove, Single comboTime, UInt32& newActionID, IGameObject targetOverride) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\CustomCombo\CustomCombo.cs:line 65
at XIVSlothCombo.Core.IconReplacer.GetIconDetour(IntPtr actionManager, UInt32 actionID) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Core\IconReplacer.cs:line 76

Was digging through the Dalamud Console and this is what starts to appear in there when addon starts breaking combo. Can provide more if needed

@zbee
Copy link
Member

zbee commented Nov 24, 2024

@timemage21 please reformat that into a code block, that is unreadable.

@timemage21
Copy link
Author

13:40:14.947 | INF | [LOCALPLUGIN] Loading WrathCombo.dll
13:40:15.260 | INF | [WrathCombo] This is ECommons v2.2.0.2 (release build without forms) and WrathCombo v1.0.0.2. Hello!
13:40:19.792 | INF | [WrathCombo] Cached 1255 preset attributes.
13:40:19.804 | INF | [LOCALPLUGIN] Finished loading "WrathCombo"
13:42:00.757 | ERR | [WrathCombo] Preset error
	System.NullReferenceException: Object reference not set to an instance of an object.
	   at XIVSlothCombo.Combos.PvE.DRG.DRG_AOE_AdvancedMode.Invoke(UInt32 actionID, UInt32 lastComboMove, Single comboTime, Byte level) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Combos\PvE\DRG\DRG.cs:line 550
	   at XIVSlothCombo.CustomComboNS.CustomCombo.TryInvoke(UInt32 actionID, Byte level, UInt32 lastComboMove, Single comboTime, UInt32& newActionID, IGameObject targetOverride) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\CustomCombo\CustomCombo.cs:line 65
	   at XIVSlothCombo.Core.IconReplacer.GetIconDetour(IntPtr actionManager, UInt32 actionID) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Core\IconReplacer.cs:line 76
13:42:00.758 | ERR | [WrathCombo] Preset error
	System.NullReferenceException: Object reference not set to an instance of an object.
	   at XIVSlothCombo.Combos.PvE.DRG.DRG_AOE_AdvancedMode.Invoke(UInt32 actionID, UInt32 lastComboMove, Single comboTime, Byte level) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Combos\PvE\DRG\DRG.cs:line 550
	   at XIVSlothCombo.CustomComboNS.CustomCombo.TryInvoke(UInt32 actionID, Byte level, UInt32 lastComboMove, Single comboTime, UInt32& newActionID, IGameObject targetOverride) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\CustomCombo\CustomCombo.cs:line 65
	   at XIVSlothCombo.Core.IconReplacer.GetIconDetour(IntPtr actionManager, UInt32 actionID) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Core\IconReplacer.cs:line 76
13:42:00.767 | ERR | [WrathCombo] Preset error
	System.NullReferenceException: Object reference not set to an instance of an object.
	   at XIVSlothCombo.Combos.PvE.DRG.DRG_AOE_AdvancedMode.Invoke(UInt32 actionID, UInt32 lastComboMove, Single comboTime, Byte level) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Combos\PvE\DRG\DRG.cs:line 550
	   at XIVSlothCombo.CustomComboNS.CustomCombo.TryInvoke(UInt32 actionID, Byte level, UInt32 lastComboMove, Single comboTime, UInt32& newActionID, IGameObject targetOverride) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\CustomCombo\CustomCombo.cs:line 65
	   at XIVSlothCombo.Core.IconReplacer.GetIconDetour(IntPtr actionManager, UInt32 actionID) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Core\IconReplacer.cs:line 76
13:42:00.767 | ERR | [WrathCombo] Preset error
	System.NullReferenceException: Object reference not set to an instance of an object.
	   at XIVSlothCombo.Combos.PvE.DRG.DRG_AOE_AdvancedMode.Invoke(UInt32 actionID, UInt32 lastComboMove, Single comboTime, Byte level) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Combos\PvE\DRG\DRG.cs:line 550
	   at XIVSlothCombo.CustomComboNS.CustomCombo.TryInvoke(UInt32 actionID, Byte level, UInt32 lastComboMove, Single comboTime, UInt32& newActionID, IGameObject targetOverride) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\CustomCombo\CustomCombo.cs:line 65
	   at XIVSlothCombo.Core.IconReplacer.GetIconDetour(IntPtr actionManager, UInt32 actionID) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Core\IconReplacer.cs:line 76
13:42:00.776 | ERR | [WrathCombo] Preset error
	System.NullReferenceException: Object reference not set to an instance of an object.
	   at XIVSlothCombo.Combos.PvE.DRG.DRG_AOE_AdvancedMode.Invoke(UInt32 actionID, UInt32 lastComboMove, Single comboTime, Byte level) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Combos\PvE\DRG\DRG.cs:line 550
	   at XIVSlothCombo.CustomComboNS.CustomCombo.TryInvoke(UInt32 actionID, Byte level, UInt32 lastComboMove, Single comboTime, UInt32& newActionID, IGameObject targetOverride) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\CustomCombo\CustomCombo.cs:line 65
	   at XIVSlothCombo.Core.IconReplacer.GetIconDetour(IntPtr actionManager, UInt32 actionID) in C:\Users\thero\Source\Repos\WrathCombo\XIVSlothCombo\Core\IconReplacer.cs:line `76```

Also first started producing errors on Battle Litany cast

@zbee
Copy link
Member

zbee commented Nov 24, 2024

Fixed in 1.0.0.3 with 366c3f2, which is being pushed.

@zbee zbee closed this as completed Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants