add param validation to nsstools::add_cert

Puppet-Finland · Feb 13, 2014 · 7bb1565 · 7bb1565
1 parent c4d4c89
commit 7bb1565
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/manifests/add_cert.pp b/manifests/add_cert.pp
@@ -15,10 +15,11 @@
 #
 # Sample Usage:
 #
-# nsstools::add_cert { '/tmp/server.crt':
-# nickname => 'GlobalSign Root CA',
-# certdir => '/etc/pki/foo',
-# }
+# nsstools::add_cert { '/tmp/server.crt':
+# nickname => 'GlobalSign Root CA',
+# certdir => '/etc/pki/foo',
+# }
+#
 #
 define nsstools::add_cert(
  $certdir,
@@ -28,6 +29,11 @@
 ) {
  include nsstools
 
+ validate_absolute_path($certdir)
+ validate_absolute_path($cert)
+ validate_string($nickname)
+ validate_string($trustargs)
+
  exec { "add_cert_${title}":
  path => ['/usr/bin'],
  command => "certutil -d ${certdir} -A -n '${nickname}' -t '${trustargs}' -a -i ${cert}",