Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Potential Issue with Include #24

Open
chaojian-zhang opened this issue Oct 27, 2023 · 2 comments
Open

[Issue] Potential Issue with Include #24

chaojian-zhang opened this issue Oct 27, 2023 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@chaojian-zhang
Copy link
Contributor

Follow recent release , the implementation of Include may also need to deal with unsafe parsing to avoid potential issues with contexts.

Also, what happens if there is Parse within Parse or Include within Include? With current monolithic (non-stack-based) state it seems it's not going to work. If that's the case, we should point that out on the front page and highlight such limit of Pure.

@chaojian-zhang
Copy link
Contributor Author

Actually Include might be fine because it's handled on the language level - it's not inside a parsing context on itself.

@chaojian-zhang chaojian-zhang added the help wanted Extra attention is needed label Dec 19, 2023
@chaojian-zhang chaojian-zhang added this to the Architectural Crisis milestone Dec 19, 2023
@chaojian-zhang
Copy link
Contributor Author

At the moment as a limit to Include (due to limited understanding😂): we assume cannot include within include.
A solution is pre-parsing (parse through all includes and generate sections of code snippets belongs to each include source, then load them one by one from the top level) with automatic cyclic handling (which is handled trivially if we were to pre-parse and load all include text blocks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant