Removed assertion failure when poll() on invalid socket

osy · osy · commit 94668cf65289 · 2022-12-11T15:51:09.000-08:00
This is a valid error condition that can be hit when, for example,
connect() is called and returned error. The socket is in an invalid state
but this assertion failure crashes the app before proper error handling
can be done elsewhere.
diff --git a/Sources/Socket/SocketManager.swift b/Sources/Socket/SocketManager.swift
@@ -257,7 +257,6 @@ extension SocketManager.ManagerState {
                     shouldRead(poll.socket)
                 }
                 if poll.returnedEvents.contains(.invalidRequest) {
-                    assertionFailure("Polled for invalid socket \(poll.socket)")
                     error(.badFileDescriptor, for: poll.socket)
                 }
                 if poll.returnedEvents.contains(.hangup) {

Original file line number	Diff line number	Diff line change
`@@ -257,7 +257,6 @@ extension SocketManager.ManagerState {`
`257`	`257`	`shouldRead(poll.socket)`
`258`	`258`	`}`
`259`	`259`	`if poll.returnedEvents.contains(.invalidRequest) {`
`260`		`- assertionFailure("Polled for invalid socket \(poll.socket)")`
`261`	`260`	`error(.badFileDescriptor, for: poll.socket)`
`262`	`261`	`}`
`263`	`262`	`if poll.returnedEvents.contains(.hangup) {`