Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node@0.04 compatibility #1

Closed
paoloricciuti opened this issue Jul 10, 2024 · 6 comments
Closed

node@0.04 compatibility #1

paoloricciuti opened this issue Jul 10, 2024 · 6 comments

Comments

@paoloricciuti
Copy link

This package doesn't seem to be compatible with node@0.04 which is exactly what I needed. Is it possible to be compatible with it?

I'm willing to make a PR for it but I will likely need to bring some dependencies. That could also help with security since currently this package is at risk of someone messing with the prototype of native objects.

@PuruVJ
Copy link
Owner

PuruVJ commented Jul 11, 2024

Good idea. Could you install the deps using pip3 though? I'm so tired of node_modules bloat. Lets rewrite this in python and ship a WASM binary :DDD

@sukeshpabolu
Copy link

@paoloricciuti you should submit a PR with 100 chungus of dependencies then only it is acceptable

@andrewdoro
Copy link

andrewdoro commented Jul 11, 2024

bro, i got the solution, will just rewrite this in c, then use node bindings

@kibertoad
Copy link

@paoloricciuti You'd need to introduce custom GitHub Actions to be able to run tests for that. And you better rewrite them in tape

@PuruVJ
Copy link
Owner

PuruVJ commented Jul 23, 2024

I don't have a heart to close this. Pinning it to the top 🤣

EDIT: It seems it stays pinned even after being closed so will close this, but good thread 😄

@PuruVJ PuruVJ pinned this issue Jul 23, 2024
@PuruVJ PuruVJ closed this as completed Jul 23, 2024
@paoloricciuti
Copy link
Author

I don't have a heart to close this. Pinning it to the top 🤣

EDIT: It seems it stays pinned even after being closed so will close this, but good thread 😄

Lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants