Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read-only access to portfolio overview #305

Merged
merged 4 commits into from
Sep 17, 2020
Merged

Conversation

Petterandre
Copy link
Contributor

@Petterandre Petterandre commented Sep 16, 2020

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off dev.
  • Check the commit's or even all commits' message
  • Check your code additions will fail linting checks
  • Remember: After PR is closed, add PR description to Changelog

Description

Added functionality: if someone is in the group "Porteføljeinnsyn" they will be able to view all projects in the portfolio on PortfolioOverview. User is not able to enter project, only view data in Porteføljeoversikt

How to test

  • 1. Add user to "Porteføljeinnsyn" group.
  • 2. View "Porteføljeoversikt"

Relevant issues (if applicable)

#243
💔Thank you!

@olemp olemp self-requested a review September 16, 2020 17:00
Copy link
Collaborator

@olemp olemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One thing though. It seems that fetchDataForManagerView and fetchDataForRegularView will be very similiar, and it would be nice to avoid a lot of duplicate code.

@Petterandre
Copy link
Contributor Author

Petterandre commented Sep 17, 2020

I didn't realize the similarities. Refactoring completed.

@tarjeieo
Copy link
Member

Did you remember to add the Group as a default group as well @Petterandre ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants