Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed view selector availability for non-admin users #308

Merged
merged 1 commit into from
Sep 18, 2020
Merged

Fixed view selector availability for non-admin users #308

merged 1 commit into from
Sep 18, 2020

Conversation

Petterandre
Copy link
Contributor

@Petterandre Petterandre commented Sep 18, 2020 •
edited by pzljanb
Loading

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off dev.
  • Check the commit's or even all commits' message
  • Check your code additions will fail linting checks
  • Remember: After PR is closed, add PR description to Changelog

Description

Removed admin-only access to view selector in Portfolio Overview.
Please refuse PR if this was is as intended.

How to test

  • Have a regular user view Portfolio Overview to see if he/she can choose view

Relevant issues (if applicable)

Closes #304

💔Thank you!

@olemp olemp self-requested a review September 18, 2020 10:15
olemp
olemp approved these changes Sep 18, 2020
View reviewed changes
Copy link
Collaborator

@olemp olemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Closes #304 (Closes keyword) to automatically link the issue with the PR.

@olemp olemp merged commit dbc50e1 into dev Sep 18, 2020
@olemp olemp deleted the issue/304 branch September 18, 2020 10:16
@Remi749 Remi749 added this to the Version 1.2.3 milestone Sep 29, 2020
This was referenced Sep 29, 2020
Closed
Closed
@pzljanb pzljanb mentioned this pull request Feb 12, 2021
Closed
25 tasks
@pzljanb pzljanb mentioned this pull request Apr 13, 2021
Closed
18 tasks
@pzljanb pzljanb mentioned this pull request Sep 3, 2021
Closed
27 tasks
@pzljanb pzljanb mentioned this pull request Oct 5, 2021
Closed
26 tasks
@pzljanb pzljanb mentioned this pull request Jan 31, 2022
Closed
19 tasks
@pzljanb pzljanb mentioned this pull request Jun 23, 2022
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemp olemp olemp approved these changes

Assignees

@Petterandre Petterandre

Labels
None yet
Projects
None yet
Milestone
Version 1.2.3
Development

Successfully merging this pull request may close these issues.

Select view dropdown in portfolio overview is not displayed for viewers
3 participants
@Petterandre @olemp @Remi749