Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rich text and lineshift support #502

Merged
merged 4 commits into from
Aug 30, 2021
Merged

Conversation

Rundez
Copy link
Contributor

@Rundez Rundez commented Aug 24, 2021

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off dev.
  • Check the commit's or even all commits' message
  • Check if your code additions will fail linting checks
  • Remember: Add PR description to CHANGELOG with the ID that matches this PR

Description

Arbeidstilsynet asked for lineshift and rich text support in the Project information web part. Some fields could be hard to read when filled with a lot of text without the ability to format.

How to test

  • Edit project properties, write lineshift in a multi-line field 'Målsetting'.
    Lineshift will be rendered in the web part on frontpage.

💔Thank you!

Injecting HTML and replacing \n with <br> tag.
@Rundez Rundez added enhancement Request that will enhance the product frontend Related to frontend customer funded Issues funded by customer labels Aug 24, 2021
@Rundez Rundez requested a review from tarjeieo August 24, 2021 08:06
@Rundez Rundez self-assigned this Aug 24, 2021
@Rundez Rundez requested a review from olemp as a code owner August 24, 2021 08:06
Copy link
Collaborator

@olemp olemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rundez Can you add an entry to the changelog?

@Rundez
Copy link
Contributor Author

Rundez commented Aug 30, 2021

Added.

@olemp olemp merged commit 33dc700 into dev Aug 30, 2021
@olemp olemp deleted the feature/arbeidstilsynet-wordwrap branch August 30, 2021 07:39
@pzljanb pzljanb added this to the 1.2.9 milestone Sep 3, 2021
@pzljanb pzljanb mentioned this pull request Sep 3, 2021
27 tasks
@pzljanb
Copy link
Contributor

pzljanb commented Sep 3, 2021

Tested OK,
Found that also coding like inline html tags can be used.
Is there a listing of which tags that can be used @Rundez ?

@Rundez
Copy link
Contributor Author

Rundez commented Sep 3, 2021

I believe that most, if not all HTML tags can be used.
@pzljanb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer funded Issues funded by customer enhancement Request that will enhance the product frontend Related to frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants