Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for syncing number and currency flds #612

Merged
merged 3 commits into from
Dec 30, 2021
Merged

Fix for syncing number and currency flds #612

merged 3 commits into from
Dec 30, 2021

Conversation

tarjeieo
Copy link
Member

@tarjeieo tarjeieo commented Dec 30, 2021

Your checklist for this pull request

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your main!
  • Make sure you are making a pull request against the dev branch (left side). Also you should start your branch off dev.
  • Check the commit's or even all commits' message
  • Check if your code additions will fail linting checks
  • Remember: Add issue description to CHANGELOG with the ID of the Issue associated with this PR
  • Documentation: Have a look at the PP365 User manual and consider the need for updates to be made. Updates can be done directly into the 'Kladd' branch or by providing information to test team for implementation.

Description

Added support for number and currency fields in project properties, to allow sync of them

How to test

Please describe how someone else (a regular user without coding skills) can test this PR. In the form of a numbered list and checkboxes for Jan when the testing period occurs.

Example:

  • 1. Create number and currency fields and add them to the Project content type of the hub
  • 2. Create project
  • 3. Edit project properties and add values to the number and currency fields
  • 4. Observe that sync of project props is working

Relevant issues (if applicable)

💔Thank you!

@tarjeieo tarjeieo requested a review from olemp as a code owner December 30, 2021 13:07
@tarjeieo tarjeieo self-assigned this Dec 30, 2021
@tarjeieo tarjeieo merged commit eff5876 into dev Dec 30, 2021
@tarjeieo tarjeieo deleted the sync-number-fields branch December 30, 2021 14:40
@tarjeieo tarjeieo added this to the 1.3.2 milestone Dec 30, 2021
@pzljanb pzljanb mentioned this pull request Jan 31, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant