Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/openstack_coverage.py is no longer needed or used #297

Closed
ericwb opened this issue May 8, 2018 · 5 comments
Closed

tools/openstack_coverage.py is no longer needed or used #297

ericwb opened this issue May 8, 2018 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@ericwb
Copy link
Member

ericwb commented May 8, 2018

Summary

We can remove tools/openstack_coverage.py since this project is no longer openstack specific. Although, we still could use a coverage job of some kind. So while removing this, we should also add a coverage job to travis CI/etc.

@ericwb ericwb added bug Something isn't working good first issue Good for newcomers labels May 8, 2018
@nickthetait
Copy link

Preference on what coverage job is used? Coverity, Coveralls, or some other tool I'm unaware of.

@ericwb
Copy link
Member Author

ericwb commented May 22, 2018

So another project I work on uses codecov.io which seems pretty good.

@nickthetait
Copy link

nickthetait commented May 23, 2018

Sure. This should be added to tox.ini or in travis.yml?
https://github.com/codecov/example-python#testing-with-tox

@ericwb
Copy link
Member Author

ericwb commented May 24, 2018

I believe in both. Travis CI should have something like:

after_success:
- codecov -e $TRAVIS_PYTHON_VERSION

And tox, so that devs can run locally.

[testenv:cover]
sitepackages = False
commands =
  coverage erase
  coverage run --source bandit -m testtools.run discover tests
  coverage html
coverage xml

@nickthetait
Copy link

I've made some progress.... https://github.com/nickthetait/bandit/tree/coverage-testing
Able to run my own Travis builds https://travis-ci.org/nickthetait/bandit but haven't yet generated a coverage report https://travis-ci.org/nickthetait/bandit/jobs/383417796#L1026
Is my assumption correct that I can setup the travis -> codecov link first without having to modify tox.ini?
What should I read up on to figure out what is wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants