Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insecure URLs that leak api-keys, usernames, and passwords #443

Open
mkbhanda opened this issue Jan 8, 2019 · 6 comments
Open

Insecure URLs that leak api-keys, usernames, and passwords #443

mkbhanda opened this issue Jan 8, 2019 · 6 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mkbhanda
Copy link

mkbhanda commented Jan 8, 2019

Is your feature request related to a problem? Please describe.
Get URLs that have parameters, whether http or https, leak sensitive information when they capture parameters such as API-Keys, usernames, and passwords. Browser extensions, bookmarks, history, and server log files capture these, even when operating in anonymous mode. Browser providers could share the information and log files need to mask the sensitive information.

Noticed sites such as Here and Google, for ease of use, suggest putting API keys in the url.
See: https://developer.here.com/documentation/geocoder/topics/quick-start-geocode.html and
https://developers.google.com/maps/documentation/roads/get-api-key

Describe the solution you'd like
It would be good to flag such 'sensitive' URL construction, alerting the developer to its potential security implications. And its complement -- alert when urls are logged in the code when they have not explicitly marked as "ignore" or have not tackled some kind of masking.

Describe alternatives you've considered
None

Additional context
https://www.fullcontact.com/blog/never-put-secrets-urls-query-parameters/

@lukehinds lukehinds added the enhancement New feature or request label Jan 9, 2019
@lukehinds
Copy link
Member

Good idea, I like it

Do you plan to work on this @mkbhanda ?

@mkbhanda
Copy link
Author

mkbhanda commented Jan 9, 2019 via email

@lukehinds
Copy link
Member

No need to have it right away @mkbhanda - I have assigned to you and if any problems, just comment or unassign yourself. thanks in advance for your contribution(s).

@knyazer
Copy link

knyazer commented Jul 3, 2024

Hey, sorry for possibly wrong ping, but @ericwb, do you mind if I take this issue? It seems to be long forgotten, and I feel like even the basic form of secret detection is useful.

@ericwb
Copy link
Member

ericwb commented Jul 4, 2024

@knyazer Sounds great! Thanks for your help.

@mkbhanda
Copy link
Author

mkbhanda commented Jul 4, 2024

Hello @ericwb ! This is a blast from the past, so many years have gone by! Thank you for picking it up @knyazer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants