Support exception aliases properly in B014 #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A good example is OSError. Since Python 3.3, IOError, EnvironmentError, select.error, etc merged into OSError and became aliases. Before this change, both the aliases and the primary exceptions were removed from the message.
ichard26
commented
Jun 28, 2020
ichard26
commented
Jun 28, 2020
Comment on lines
+185
to
+191
| # Find and remove aliases exceptions and only leave the primary alone | ||
| primaries = filter( | ||
| lambda primary: primary in good, B014.exception_aliases.keys() | ||
| ) | ||
| for primary in primaries: | ||
| aliases = B014.exception_aliases[primary] | ||
| good = list(filter(lambda e: e not in aliases, good)) |
There was a problem hiding this comment.
Perhaps this is a bit over-engineered. I could just define an edge-case for OSError.
Thoughts?
Copy of original review because I modified this code afterwards to be more functional with filter
There was a problem hiding this comment.
Na seems fine to me and makes sense.
cooperlees
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
Looks good to me, maybe I'll give it a few days for @Zac-HD to agrees too ...
Comment on lines
+185
to
+191
| # Find and remove aliases exceptions and only leave the primary alone | ||
| primaries = filter( | ||
| lambda primary: primary in good, B014.exception_aliases.keys() | ||
| ) | ||
| for primary in primaries: | ||
| aliases = B014.exception_aliases[primary] | ||
| good = list(filter(lambda e: e not in aliases, good)) |
There was a problem hiding this comment.
Na seems fine to me and makes sense.
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #110
Resolves #126