make sure float infinity/NaN does not trigger B008 #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We do have CI. I don't know why it triggered. I clicked re-run and it seems to be running now. Lets see how things go in the older versions of python. Thanks! Edit: They all passed. |
cooperlees
approved these changes
Jan 28, 2021
This was referenced Mar 9, 2021
This was referenced Mar 16, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #154, and make sure float infinity/NaN does not trigger a B008 error. Some unit tests are added.
I tested this code on Python 3.9, I don't know how to test this on Python 3.7 or below (note that this is needed because the ast
module behavior for constants changed), do you have regressions that check across versions automatically?