-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B950 does not give warnings when --extend-ignore'ing E501 #266
Comments
The referenced cleanup would be good to do but it's not going to fix this specific issue. I think the solution is ultimately an upstream one, but regardless of what the resolution ends up being this plugin's README should provide an example configuration that provides the expected results for a currently released version of Flake8, which it hasn't done since it was changed in #218 (sorry!). To help with the near term, I would propose that we do the cleanup tasks (if you're open to them now) and revert the README example to use
I would expect this to report both |
This should now be resolved upstream via PyCQA/flake8#1609 🎉
IMO the README should still be reverted until Flake8 next is released. |
Flake8 5.0 has landed with these changes: https://flake8.pycqa.org/en/latest/release-notes/5.0.0.html |
So, do we close now or is there still cleanup on our side? |
In an empty folder (no .flake8, tox.ini, or setup.cfg present)
Gives me no errors.
Adding verbose logging (
-vv
) tells me:It appears that
--extend-ignore=E501
makes flake8 think it can ignore B950 because E501 is part of the default ignore list. And I can't find any flake8 or bugbear version combination where this has ever worked...The reported debugging info for B950 is the same as when not using any ignores at all.
Using
--ignore=E501
instead of--extend-ignore
makes it work as expected, but of course we don't want to override the default ignore list.In total the following table shows all issues:
Not sure about the second last line, whether it is expected to report both E501 and B950 or E501 alone...
The text was updated successfully, but these errors were encountered: