-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specific error codes specified with # NOQA are not detected when no colon is used #275
Comments
In GitLab by @jeverling on Oct 26, 2018, 07:02 mentioned in merge request !260 |
In GitLab by @asottile on Oct 26, 2018, 08:29 heh, I had the same misunderstanding about that code comment (it's referring to regex capture, not the functionality of the regex itself). |
In GitLab by @jeverling on Oct 26, 2018, 09:01 Oooh, I searched but somehow missed that issue. Thanks for the explanation, |
In GitLab by @asottile on Oct 26, 2018, 09:27 It might be worth doing this anyway. I've seen these "mistake" forms, and we might want to just match those anyway?
curious to hear what @sigmavirus24 thinks on this subject :) |
In GitLab by @sigmavirus24 on Oct 27, 2018, 05:37 The I'd be open to Further, other tools have adopted the syntax already so making too many changes will have knock-on effects elsewhere and I don't hate other developers/maintainers enough to put that onus on them. |
In GitLab by @jeverling on Oct 28, 2018, 12:18 mentioned in merge request !262 |
In GitLab by @jeverling on Oct 28, 2018, 12:24 Thanks @sigmavirus24 for the explanation, that's a good reason. Like @asottile I have seen the |
In GitLab by @jeverling on Oct 28, 2018, 13:25 closed via commit cafe780 |
In GitLab by @asottile on Oct 28, 2018, 13:25 closed via merge request !262 |
In GitLab by @asottile on Oct 28, 2018, 13:27 Reopening in case someone wants to tackle the |
In GitLab by @asottile on Oct 28, 2018, 13:27 reopened |
In GitLab by @sigmavirus24 on Oct 28, 2018, 17:19 What about creating a new issue for that? It'll be clearer what is desired |
In GitLab by @asottile on Oct 28, 2018, 17:21 sounds good -- I'll do that 👍 |
In GitLab by @asottile on Oct 28, 2018, 17:21 closed |
In GitLab by @jeverling on Oct 26, 2018, 05:01
Omitting
flake8 --bug-report
and "how I installed flake8" because the bug exists in the master branch of the flake8 repo.The regex that is used to check if there are error codes provided with a
# NOQA
instruction doesn't work without a colon, but it should, according to the comment in defaults.py#L33:Actually the regex does not capture the error code when no colon is used, resulting in only
# NOQA
which suppresses all errors.The text was updated successfully, but these errors were encountered: