-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't reset indent_char when we encounter E101 - [merged] #949
Comments
In GitLab by @sigmavirus24 on Sep 25, 2019, 15:56 I didn't fully understand what this was doing in pycodestyle and I was refactoring the several hundred line function into this to try to keep backwards compatibility. I suspect this was introduced at one point to detect/fix something, but I genuinely don't know what. |
In GitLab by @asottile on Sep 25, 2019, 16:20 yeah I traced it back to the initial commit in pep8 and didn't seem to have a reason for it. the indent character will have already been set to a tab if that was the first indent anyway so I didn't really see a reason to make it switch back and forth (and still trigger the E101 error) |
In GitLab by @sigmavirus24 on Sep 25, 2019, 16:42 Sounds good. I trust you |
In GitLab by @sigmavirus24 on Sep 25, 2019, 16:42 merged |
In GitLab by @sigmavirus24 on Sep 25, 2019, 16:42 mentioned in commit 6bae5f7 |
In GitLab by @asottile on Jan 16, 2020, 10:56 mentioned in merge request !88 |
In GitLab by @asottile on Sep 24, 2019, 14:38
Merges remove_E101_indent_char_resetting -> master
from PyCQA/pycodestyle#886
The text was updated successfully, but these errors were encountered: