Don't reset indent_char when we encounter E101 - [merged]

[asottile]

In GitLab by @asottile on Sep 24, 2019, 14:38

Merges remove_E101_indent_char_resetting -> master

from PyCQA/pycodestyle#886

[asottile]

In GitLab by @sigmavirus24 on Sep 25, 2019, 15:56

I didn't fully understand what this was doing in pycodestyle and I was refactoring the several hundred line function into this to try to keep backwards compatibility.

I suspect this was introduced at one point to detect/fix something, but I genuinely don't know what.

[asottile]

In GitLab by @asottile on Sep 25, 2019, 16:20

yeah I traced it back to the initial commit in pep8 and didn't seem to have a reason for it. the indent character will have already been set to a tab if that was the first indent anyway so I didn't really see a reason to make it switch back and forth (and still trigger the E101 error)

[asottile]

In GitLab by @sigmavirus24 on Sep 25, 2019, 16:42

Sounds good. I trust you

[asottile]

In GitLab by @sigmavirus24 on Sep 25, 2019, 16:42

merged

[asottile]

In GitLab by @sigmavirus24 on Sep 25, 2019, 16:42

mentioned in commit 6bae5f7

[asottile]

In GitLab by @asottile on Jan 16, 2020, 10:56

mentioned in merge request !88