Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to add empty line(s) between top-level package imports #2104

Open
superlevure opened this issue Mar 2, 2023 · 1 comment · Fixed by loft-orbital/isort#1 · May be fixed by #2313
Open

Option to add empty line(s) between top-level package imports #2104

superlevure opened this issue Mar 2, 2023 · 1 comment · Fixed by loft-orbital/isort#1 · May be fixed by #2313

Comments

@superlevure
Copy link

superlevure commented Mar 2, 2023 •
edited
Loading

Hi!

I've looked extensively in the documentation but I don't think there's a way to add an empty line between top-level package imports so this:

import os
import sys

from django.db.models.signals import m2m_changed
from django.utils import functional
from django_filters import BooleanFilter
from junitparser import JUnitXml
from junitparser import TestSuite
from loguru import logger

Would turn into this:

import os
import sys

from django.db.models.signals import m2m_changed
from django.utils import functional

from django_filters import BooleanFilter

from junitparser import JUnitXml
from junitparser import TestSuite

from loguru import logger

Am I missing something?

If it is indeed not possible, I'd be willing to push a PR to implement the option. Any push-back ?
@superlevure superlevure changed the title Option to add empty line(s) between top-level package import Option to add empty line(s) between top-level package imports Mar 2, 2023
@thibaut-lo
Copy link

I think that would be a very cool feature @anirudnits.

@lucas-bremond lucas-bremond mentioned this issue May 8, 2024
Open
This was referenced Dec 11, 2024
Merged
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@superlevure @thibaut-lo