-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pyroma 2.4 breaks prospector #276
Comments
Confirmed |
As there have been some changes in the available checks in Pyroma recently, make the initialization more robust and future-proof dynamically creating the mapping of available checks and Prospector codes, using PYRUNKNOWN for eventual new checks not yet mapped in Prospector. Closes prospector-dev#276
… Original PR commit message: "Fix Pyroma >= 2.4 initialization"
@volans- thanks for the PR. I fixed this locally before noticing your PR however yours is a better approach so I merged it over the top of my fix :-) |
Version 1.1.2 has this fix. |
Thanks for the quick fix! |
@carlio thanks for accepting my PR and make already new release! I've tried to keep the diff at the minimum in that PR, but I think it's possible to clean it up a bit more in case you want, getting rid of both |
I get this error when running prospector with pyroma 2.4 installed.
The text was updated successfully, but these errors were encountered: