Fix false positive for unhashable-member when subclassing `dict…

…`. (#7757) Closes #7501 Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
pylint-dev · Nov 17, 2022 · fa618cb · fa618cb
1 parent 19c205d
commit fa618cb
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/doc/whatsnew/fragments/7501.false_positive b/doc/whatsnew/fragments/7501.false_positive
@@ -0,0 +1,3 @@
+Fix false positive for ``unhashable-member`` when subclassing ``dict`` and using the subclass as a dictionary key.
+
+Closes #7501
diff --git a/pylint/checkers/utils.py b/pylint/checkers/utils.py
@@ -1955,7 +1955,7 @@ def is_hashable(node: nodes.NodeNG) -> bool:
     """
     try:
         for inferred in node.infer():
-            if inferred is astroid.Uninferable:
+            if inferred is astroid.Uninferable or isinstance(inferred, nodes.ClassDef):
                 return True
             if not hasattr(inferred, "igetattr"):
                 return True

diff --git a/tests/functional/u/unhashable_member.py b/tests/functional/u/unhashable_member.py
@@ -22,3 +22,9 @@ class Unhashable:
 {"tomato": "tomahto"}
 {dict: {}}
 {lambda x: x: "tomato"}  # pylint: disable=unnecessary-lambda
+
+
+class FromDict(dict):
+    ...
+
+{FromDict: 1}
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		Fix false positive for ``unhashable-member`` when subclassing ``dict`` and using the subclass as a dictionary key.

		Closes #7501