Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local dependencies of local dependencies packaging broken in 0.13.3 #1113

Closed
2 tasks done
Tpt opened this issue Sep 18, 2022 · 3 comments · Fixed by #1114
Closed
2 tasks done

Local dependencies of local dependencies packaging broken in 0.13.3 #1113

Tpt opened this issue Sep 18, 2022 · 3 comments · Fixed by #1114
Labels
bug Something isn't working sdist Source distribution

Comments

@Tpt
Copy link
Contributor

Tpt commented Sep 18, 2022

Bug Description

In Maturin 0.13.3 when running maturin stdist, the handling of relative path of local dependencies of local dependencies changed, breaking pyoxigraph build.

The current Oxigraph crate structure is:

  • /pyoxigraph (with dependency on oxigraph with path = "../oxigraph")
  • /oxigraph (with dependency on oxrdf with path = "oxrdf")
  • /oxigraph/oxrdf
  • With Maturin 0.13.2, local_dependencies/oxigraph/Cargo.toml contains oxrdf = { path= "../oxrdf", version = "0.1.0" }
  • With Maturin 0.13.3, local_dependencies/oxigraph/Cargo.toml contains oxrdf = { path= "oxrdf", version = "0.1.0" }

Nothing else has changed in the build. This change in local path leads to a cargo metadata error on installation.

PS: thank you so much for Maturin and all the improvements that are done version after version. This tool development is amazing to follow.

Your Python version (python -V)

Python 3.10.6

Your pip version (pip -V)

pip 22.0.4

What bindings you're using

pyo3

Does cargo build work?

  • Yes, it works

If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)?

  • Yes

Steps to Reproduce

GitHub CI output: https://github.com/oxigraph/oxigraph/actions/runs/3075557229/jobs/4970230508

Or:

  1. git clone --recursive https://github.com/oxigraph/oxigraph
  2. maturin sdist -m python/Cargo.toml
  3. pip install target/wheels/*.tar.gz
@messense
Copy link
Member

Sorry for the breakage, can you give #1114 a try?

@messense
Copy link
Member

I tried maturin sdist then unpack the sdist and run maturin build in it, it works fine.

@Tpt
Copy link
Contributor Author

Tpt commented Sep 18, 2022

Sorry for the breakage, can you give #1114 a try?

Yes, it works well! Your speed is amazing! Thank you!

@messense messense added the sdist Source distribution label Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sdist Source distribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants