Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding lto = "thin" to generated Cargo.toml's release profile #1529

Open
itamarst opened this issue Mar 23, 2023 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@itamarst
Copy link
Contributor

In my experience, thin LTO always give a small but noticeable performance boost to PyO3 Python extensions. As such, it would be nice if maturin just added it; one less thing for users to know they have to do.

[profile.release]
lto = "thin"
@itamarst itamarst added the enhancement New feature or request label Mar 23, 2023
@konstin
Copy link
Member

konstin commented Mar 23, 2023

i haven't been following the upstream discussion, what is the reason that cargo doesn't activate this by default if it gives a noticeable performance boost?

@itamarst
Copy link
Contributor Author

I assume because of slower compile time.

@konstin
Copy link
Member

konstin commented Mar 23, 2023

in that case i would rather align with what cargo is doing; i likely makes sense to ask for that in the cargo repo specifically, the best match i found is rust-lang/cargo#11298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants