Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross-compiling to win no longer possible with the new sdk #2118

Closed
1 of 2 tasks
btel opened this issue Jun 24, 2024 · 2 comments · Fixed by #2123
Closed
1 of 2 tasks

cross-compiling to win no longer possible with the new sdk #2118

btel opened this issue Jun 24, 2024 · 2 comments · Fixed by #2123
Labels
bug Something isn't working cross-compile Something related to cross compilation upstream Upstream issue

Comments

@btel
Copy link

btel commented Jun 24, 2024

Bug Description

When trying to cross-compile windows binaries on linux I am receiving the error:

💥 maturin failed
  Caused by: Failed to build a native library through cargo
  Caused by: no cab files were referenced by the MSI

See upstream issue on cargo-xwin: Jake-Shadle/xwin#126

The proposed solution is to provide the sdk version using the --sdk-version command line argument, but it's not clear how to pass it via maturin.

Your maturin version (maturin --version)

1.6.0

Your Python version (python -V)

3.11

Your pip version (pip -V)

23.0.1

What bindings you're using

pyo3

Does cargo build work?

  • Yes, it works

If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)?

  • Yes

Steps to Reproduce

maturin build --release --target x86_64-pc-windows-msvc -i python3.11

@btel btel added the bug Something isn't working label Jun 24, 2024
@messense
Copy link
Member

You can try set env var XWIN_VERSION=16.

@messense messense added the upstream Upstream issue label Jun 25, 2024
@btel
Copy link
Author

btel commented Jun 25, 2024

great, this worked! Thank you!

@messense messense added the cross-compile Something related to cross compilation label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cross-compile Something related to cross compilation upstream Upstream issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants