Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abi3 binding wheel can only be installed for a specific version of python #382

Closed
houqp opened this issue Nov 16, 2020 · 2 comments
Closed

Comments

@houqp
Copy link
Contributor

houqp commented Nov 16, 2020

Please provide the following information:

  • Your python version (python -V): Tested with python 3.7 and 3.9
  • Your pip version (pip -V): pip 20.2.4 from /usr/local/lib/python3.9/site-packages/pip (python 3.9)
  • The version of the bindings you're using, if any (e.g. pyo3, rust-cpython or cffi): pyo3
  • Does cargo build work? yes
  • If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)? Unix

Please list the exact steps required to reproduce your error with all command output and if possible with a repository:

  • use latest master branch to build pyo3 wheel
  • produced wheel target/wheels/libname-0.1.0-cp39-abi3-macosx_10_7_x86_64.whl, which works with python 3.9
  • try to install wheel with python 3.7: ERROR: libname-0.1.0-cp39-abi3-macosx_10_7_x86_64.whl is not a supported wheel on this platform.
  • rename wheel to libname-0.1.0-cp37-abi3-macosx_10_7_x86_64.whl fixes installation issue with python 3.7

Dynamic module contained within the wheel is named without python version: libname/libname.abi3.so. So I am guessing it's safe for us to upload the same wheel with different names for each version of python 3 to pypi?

@konstin
Copy link
Member

konstin commented Dec 1, 2020

This depends on PyO3/pyo3#1195 and PyO3/pyo3#1263 being figured out.

@konstin
Copy link
Member

konstin commented Jan 14, 2021

Fixed in 0.9.0 🎉

@konstin konstin closed this as completed Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants