Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing README to PyPI #552

Closed
djc opened this issue May 28, 2021 · 6 comments
Closed

Publishing README to PyPI #552

djc opened this issue May 28, 2021 · 6 comments

Comments

@djc
Copy link

djc commented May 28, 2021

Please provide the following information:

  • Your python version (python -V): 3.9.2
  • Your pip version (pip -V): 21.1
  • The version of the bindings you're using, if any (e.g. pyo3, rust-cpython or cffi): pyo3
  • Does cargo build work? yes
  • If on windows, have you checked that you aren't accidentally using unix path (those with the forward slash /)? N/A

Not sure if this a bug or feature request, but I would like to publish a README to my PyPI project. I tried adding a pyproject.toml file with, among other things, a project.readme key, but this did not seem to have any effect (neither did any of the other fields I set in pyproject.toml, so maybe I'm doing something wrong).

@messense
Copy link
Member

#465 PEP 621 support is not implemented yet, but you can specific readme in Cargo.toml.

@djc
Copy link
Author

djc commented May 28, 2021

Maybe "maturin supports building through pyproject.toml" in the README should be rephrased then? It gave me the impression that pyproject.toml was supported. (Setting the metadata correctly in Cargo.toml seems to have worked fine, thanks!)

@djc djc closed this as completed May 28, 2021
@messense
Copy link
Member

I think that was talking about PEP 517.

@djc
Copy link
Author

djc commented May 28, 2021

Sure, but it's likely still going to be unclear to some part of the audience.

@konstin
Copy link
Member

konstin commented May 28, 2021

Yeah it was clear until pypa changed the meaning of pyproject.toml, now it can mean two different things with varying levels of support by various tools. I mean I'm happy about PEP 621, but we really lack good terms to describe parts of python packaging. We don't even have a name for the modern build system other than pep517, which isn't understandable for most users. For that reason I avoided mentioning PEP 517 in the readme, but wouldn't mind clarifying this now that PEP 621 exists.

@messense
Copy link
Member

@djc I'm working on PEP 621 support in #555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants