add tests

Author: Icxolu

src/conversion.rs

@@ -602,3 +602,38 @@ impl<'py> IntoPyObject<'py> for () {
 /// })
 /// ```
 mod test_no_clone {}
+
+#[cfg(test)]
+mod tests {
+    use crate::{types::PyAnyMethods, FromPyObject, IntoPyObject, PyErr, Python};
+
+    #[test]
+    #[cfg(feature = "macros")]
+    fn test_pyclass_skip_from_py_object() {
+        #[crate::pyclass(crate = "crate", skip_from_py_object)]
+        #[derive(Clone)]
+        struct Foo(i32);
+
+        impl<'py> FromPyObject<'_, 'py> for Foo {
+            type Error = PyErr;
+
+            fn extract(obj: crate::Borrowed<'_, 'py, crate::PyAny>) -> Result<Self, Self::Error> {
+                if let Ok(obj) = obj.cast::<Self>() {
+                    Ok(obj.borrow().clone())
+                } else {
+                    obj.extract::<i32>().map(Self)
+                }
+            }
+        }
+        Python::attach(|py| {
+            let foo1 = 42i32.into_pyobject(py)?;
+            assert_eq!(foo1.extract::<Foo>()?.0, 42);
+
+            let foo2 = Foo(0).into_pyobject(py)?;
+            assert_eq!(foo2.extract::<Foo>()?.0, 0);
+
+            Ok::<_, PyErr>(())
+        })
+        .unwrap();
+    }
+}

tests/ui/invalid_pyfunction_argument.rs

@@ -6,4 +6,13 @@ fn invalid_pyfunction_argument(arg: AtomicPtr<()>) {
     let _ = arg;
 }
 
+#[pyclass(skip_from_py_object)]
+#[derive(Clone)]
+struct Foo;
+
+#[pyfunction]
+fn skip_from_py_object_without_custom_from_py_object(arg: Foo) {
+    let _ = arg;
+}
+
 fn main() {}

tests/ui/invalid_pyfunction_argument.stderr

@@ -6,11 +6,7 @@ error[E0277]: `AtomicPtr<()>` cannot be used as a Python function argument
   |
   = note: implement `FromPyObject` to enable using `AtomicPtr<()>` as a function argument
   = note: `Python<'py>` is also a valid argument type to pass the Python token into `#[pyfunction]`s and `#[pymethods]`
-  = help: the following other types implement trait `PyFunctionArgument<'a, 'holder, 'py, IMPLEMENTS_FROMPYOBJECT>`:
-            `&'a pyo3::Bound<'py, T>` implements `PyFunctionArgument<'a, '_, 'py, false>`
-            `&'holder T` implements `PyFunctionArgument<'a, 'holder, '_, false>`
-            `&'holder mut T` implements `PyFunctionArgument<'a, 'holder, '_, false>`
-            `Option<T>` implements `PyFunctionArgument<'a, 'holder, 'py, false>`
+  = help: the trait `PyClass` is implemented for `Foo`
   = note: required for `AtomicPtr<()>` to implement `FromPyObject<'_, '_>`
   = note: required for `AtomicPtr<()>` to implement `PyFunctionArgument<'_, '_, '_, true>`
 note: required by a bound in `extract_argument`
@@ -69,3 +65,27 @@ note: required by a bound in `extract_argument`
 ...
   |     T: PyFunctionArgument<'a, 'holder, 'py, IMPLEMENTS_FROMPYOBJECT>,
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `extract_argument`
+
+error[E0277]: `Foo` cannot be used as a Python function argument
+  --> tests/ui/invalid_pyfunction_argument.rs:14:59
+   |
+14 | fn skip_from_py_object_without_custom_from_py_object(arg: Foo) {
+   |                                                           ^^^ the trait `ExtractPyClassWithClone` is not implemented for `Foo`
+   |
+   = note: implement `FromPyObject` to enable using `Foo` as a function argument
+   = note: `Python<'py>` is also a valid argument type to pass the Python token into `#[pyfunction]`s and `#[pymethods]`
+   = help: the following other types implement trait `PyFunctionArgument<'a, 'holder, 'py, IMPLEMENTS_FROMPYOBJECT>`:
+             `&'a pyo3::Bound<'py, T>` implements `PyFunctionArgument<'a, '_, 'py, false>`
+             `&'holder T` implements `PyFunctionArgument<'a, 'holder, '_, false>`
+             `&'holder mut T` implements `PyFunctionArgument<'a, 'holder, '_, false>`
+             `Option<T>` implements `PyFunctionArgument<'a, 'holder, 'py, false>`
+   = note: required for `Foo` to implement `FromPyObject<'_, '_>`
+   = note: required for `Foo` to implement `PyFunctionArgument<'_, '_, '_, true>`
+note: required by a bound in `extract_argument`
+  --> src/impl_/extract_argument.rs
+   |
+   | pub fn extract_argument<'a, 'holder, 'py, T, const IMPLEMENTS_FROMPYOBJECT: bool>(
+   |        ---------------- required by a bound in this function
+...
+   |     T: PyFunctionArgument<'a, 'holder, 'py, IMPLEMENTS_FROMPYOBJECT>,
+   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `extract_argument`