Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support from_py_with on struct tuples and enums #1441

Closed
daniil-konovalenko opened this issue Feb 20, 2021 · 0 comments · Fixed by #2181
Closed

Support from_py_with on struct tuples and enums #1441

daniil-konovalenko opened this issue Feb 20, 2021 · 0 comments · Fixed by #2181
Labels
enhancement Good First Issue needs-implementer

Comments

@daniil-konovalenko
Copy link
Contributor

daniil-konovalenko commented Feb 20, 2021 •
edited
Loading

in continuation of #1239

In #1411 we added support for from_py_with inside #[derive(FromPyObjects)] on structs, but we left out tuple structs and enums.

It would be nice to support them as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Good First Issue needs-implementer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for from_py_with on struct tuples and enums ricohageman/pyo3
2 participants
@davidhewitt @daniil-konovalenko