Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PyDict_Merge on PyDict #2910

Closed
samuelcolvin opened this issue Jan 25, 2023 · 1 comment · Fixed by #2912
Closed

Support PyDict_Merge on PyDict #2910

samuelcolvin opened this issue Jan 25, 2023 · 1 comment · Fixed by #2912
Labels
enhancement

Comments

@samuelcolvin
Copy link
Contributor

samuelcolvin commented Jan 25, 2023 •
edited
Loading

Would be great to have support for PyDict_Merge on PyDict, e.g. via a fn merge(other: &PyDict, override: bool) method.
@samuelcolvin
Copy link
Contributor Author

Then worth adding in a docs that .merge(other, true) is akin to a.update(b) in python, we could either add .update() as either an alias to .merge() or using PyDict_Update directly.

@samuelcolvin samuelcolvin mentioned this issue Jan 25, 2023
Merged
3 tasks
@bors bors bot closed this as completed in 141cbea Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add PyDict.update() and PyDict.update_if_missing() samuelcolvin/pyo3
1 participant
@samuelcolvin