-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug with zip sdists? #11
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I don't understand what this code is supposed to be doing, but it doesn't seem right.
When parsing an
SDistType::Zip
,parse_zip
is called with"PKG-INFO"
:python-pkginfo-rs/src/distribution.rs
Line 154 in dc97929
parse_zip
finds all the contained file paths that end with"PKG-INFO"
:python-pkginfo-rs/src/distribution.rs
Lines 206 to 210 in dc97929
If there is one path ending with
"PKG-INFO"
, it is used:python-pkginfo-rs/src/distribution.rs
Lines 213 to 217 in dc97929
If there are two paths ending with
"PKG-INFO"
and either of them ends with".egg-info/PKG-INFO"
, the first one is used:python-pkginfo-rs/src/distribution.rs
Lines 218 to 225 in dc97929
I don't understand in what cases there would be two paths that end with
"PKG-INFO"
, but it seems like if the code is checking that one of them ends with".egg-info/PKG-INFO"
, the path that gets used should be related to the result of that check. It also seems like there is a problem if both of the paths end with".egg-info/PKG-INFO"
.The text was updated successfully, but these errors were encountered: